fix code review remarks

NOTES.md

@@ -1,21 +0,0 @@
-# Notes
-
-## Item Questions
-
-QUESTIONS ABOUT ITEMS
-- I think: key items are uncountable.  everything else is countable.  an item can be held iff it is countable.
-- how long do
-- check bp for ultimate held item ref or something
-- I need a better way to represent NPC interactions in different games
-- how much does growth mulch accelerate soil drying?  how much does damp mulch slow it?
-- does lum berry cure confusion?
-- how does sweet heart work?  it seems a guy in mistralton will trade some for heart scales?
-- kind of guessing about the * urge items
-
-CHANGES SINCE R/S
-- 4 shoal salt + 4 shoal shells, traded to a guy in Shoal Cave, make a Shell Bell
-- white flute increased encounter rate by 50%, not 100%
-- shards can be traded for the respective stones
-
-
-UP TO 67

README.md

@@ -14,7 +14,7 @@ to maintain for the games and generations to come.
 
 ### Status of the YAML migration
 
-**Update from 18.06.2017**
+**Update from 2017-06-18**
 
 @eevee started on an experiment with switching to YAML for data storage some time ago, for a variety of reasons.
 It's finally starting to show some promise — all of gen 7 was dumped to a YAML format, then loaded into the database
@@ -82,7 +82,7 @@ Dumping the SQLite database back into the CSV files:
 bin/docker-pokedex dump -l all
 ```
 
-You also have a special command to re-build the docker image:
+You also have a special command to re-build the docker image (e.g. after editing files):
 ```bash
 bin/docker-pokedex rebuild
 ```

bin/docker-pokedex

@@ -0,0 +1,20 @@
+#!/usr/bin/env bash
+
+curr_dir="$(pwd)"
+log_file="${curr_dir}/bin/docker-pokedex.log"
+
+if [[ "${1}" = "rebuild" ]] || [[ ! -f "${log_file}" ]]; then
+    docker build --rm -t veekun/pokedex ${curr_dir}
+    echo "$(date)" >> "${log_file}"
+
+    if [[ "${1}" = "rebuild" ]]; then
+        echo "Docker container rebuilt"
+        exit
+    fi;
+fi
+
+docker run -it --rm \
+    -e TERM=xterm-256color \
+    --name "pokedex-$(date +%Y%m%d-%H%M%S)" \
+    --mount type=bind,source="${curr_dir}/pokedex/data",target=/app/pokedex/data \
+    veekun/pokedex "${@}"

setup.py

@@ -2,10 +2,9 @@ from setuptools import setup, find_packages
 
 setup(
     name='Pokedex',
-    version='0.2',
+    version='0.1',
     zip_safe=False,
     packages=find_packages(),
-    hiddenimports=['six'],
     package_data={
         'pokedex': ['data/csv/*.csv']
     },